Skip to content

Spread props #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 9, 2019
Merged

Spread props #1

merged 15 commits into from
Jan 9, 2019

Conversation

jiliabas
Copy link
Owner

@jiliabas jiliabas commented Jan 8, 2019

spread props for 'extends' and 'mixins'

@jiliabas jiliabas requested a review from coco1979ka January 8, 2019 13:29
@jiliabas
Copy link
Owner Author

jiliabas commented Jan 8, 2019

test is done

@jiliabas jiliabas requested review from Musictrunk and ValTM January 9, 2019 14:49
coco1979ka
coco1979ka requested changes Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@coco1979ka coco1979ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also test array props in Parent0 instead of using object props?

@jiliabas jiliabas merged commit c7fb693 into master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coco1979ka coco1979ka coco1979ka approved these changes

@Musictrunk Musictrunk Awaiting requested review from Musictrunk

@ValTM ValTM Awaiting requested review from ValTM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiliabas @coco1979ka